Easily add the ability to use model methods as Form Validation rules. #866
Conversation
Adds one public method to set a model name or array of models that will be checked. Slightly modifies the _execute() method to check for rules in models before continuing the hunt. Originally I added a simple public method to Loader() which would return the protected $_ci_models array to see if it was already loaded but thought just trying to load the model was less intrusive as it will just return the model if it is or load and it if it isn't.
|
👍 |
|
I support this request - would be very useful and help centralize validation. |
|
I certainly agree with adding the ability to use model methods as validation rules (actually I would prefer even more expandability than that, but I digress). Just not sure this is the best method for doing it. There's potential for conflicts; if your model has a Maybe collectively we can improve upon this or figure out a better solution. |
| @@ -616,7 +658,7 @@ protected function _execute($row, $rules, $postdata = NULL, $cycles = 0) | |||
| continue; | |||
| } | |||
|
|
|||
| $result = $this->$rule($postdata, $param); | |||
| $result = ($found_in_model) ? $this->CI->$model->$rule($postdata, $param) : $this->$rule($postdata, $param); | |||
There was a problem hiding this comment.
Also, pretty sure there is a bug here. In $this->CI->$model->$rule($postdata, $param), I believe $modelshould be $found_model.
|
I would like to see this implemented with a little more flexibility. I have added the ability to route callback functions to controllers in my HMVC implementation, where you can specify any Controller and it will be loaded if necessary and the function called. I imagine a similar mechanism for callbacks on models. What if Form_validation accepted a new prefix like 'callmodel_' which could be followed by a model name and function? (e.g. - 'callmodel_mymodel/newrule') I think this would be much more widely usable, and not limit the rules to a single model. |
|
#312 is a better approach to the problem. |
-Adds one public method to set a model name or array of models that will be checked for rules.
-Slightly modifies the _execute() method to check for rules in models before continuing the hunt.
Originally I added a simple public method to Loader() which would return the protected $_ci_models array to see if it was already loaded but thought just trying to load the model was less intrusive as it will just return the model if it is or load and it if it isn't.
I will gladly amend the related docs if this change is accepted.