Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

prepend project names with API user's id #134

Merged
merged 20 commits into from
Oct 8, 2020

Conversation

aerickson
Copy link
Collaborator

@aerickson aerickson commented Oct 7, 2020

Whenever we switch accounts running devicepool we've had to share the project with the new owner in the Bitbar UI.

Try to avoid that completely by having each user create their own projects.

This code prepends the user id to the project name that is used at bitbar.

@aerickson aerickson changed the title prepend project names with API user id prepend project names with API user's id Oct 7, 2020
@aerickson aerickson requested a review from bclary October 7, 2020 00:42
Copy link
Owner

@bclary bclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+. This looks fine. Let's pick a slow period and try it out.

@aerickson
Copy link
Collaborator Author

Configuration worked well, but the new role account didn't have access to the zip files. I didn't want to share them, so I generated new ones.

Everything seems to be working.

@aerickson
Copy link
Collaborator Author

The service seems to be starting way too many jobs... active queries aren't detecting the jobs already started by the previous user? Stopping the service for a bit... until all jobs from the previous owner are clear.

@aerickson
Copy link
Collaborator Author

It was the new user's jobs that it couldn't see. test_run_manager:process_active_runs needed to use the appended name.

Fixed and working now. LMK if you'd like me to refactor any of the recent changes.

@aerickson aerickson marked this pull request as ready for review October 7, 2020 20:53
@aerickson aerickson merged commit f4d562a into bclary:master Oct 8, 2020
@aerickson aerickson deleted the role_account_debug branch October 8, 2020 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants