Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of errors #9

Closed
wants to merge 1 commit into from
Closed

Conversation

loewenheim
Copy link

So far, I’ve only removed the failure dependency.

@bcmyers
Copy link
Owner

bcmyers commented Feb 6, 2019

@loewenheim, again, thanks for the PR! This seems to be failing for a similar reason to your other PR. In the areas of the code that are not explicitly marked [cfg(features = "std")], we can't use anything from the standard library; everything has to come from core instead. I'm going to do some thinking about how I'd like errors to work; so perhaps we should table this PR for now.

@bcmyers bcmyers closed this Feb 6, 2019
@bcmyers
Copy link
Owner

bcmyers commented Feb 6, 2019

See comment above.

@loewenheim loewenheim deleted the errors branch February 6, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants