Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sometimes dead loop, maybe should update foreground-child version #495

Closed
loynoir opened this issue Oct 16, 2023 · 2 comments
Closed

sometimes dead loop, maybe should update foreground-child version #495

loynoir opened this issue Oct 16, 2023 · 2 comments
Labels
bug help wanted Issue is well defined but needs assignment

Comments

@loynoir
Copy link

loynoir commented Oct 16, 2023

  • Version: 8.0.1
  • Platform: Docker ArchLinux

Related

tapjs/foreground-child#54

From test output, seems test is completed.

...
ℹ tests 150
ℹ suites 74
ℹ pass 138
ℹ fail 0
ℹ cancelled 0
ℹ skipped 12
ℹ todo 0
ℹ duration_ms 18647.069542
(stuck)

Then stuck with 100% CPU, guess somehow dead loop with foreground-child@2.0.0

After Ctrl-C

ypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('128SIGINT')
    at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
    at ChildProcess.<anonymous> (/home/vscode/.yarn/berry/cache/foreground-child-npm-2.0.0-80c976b61e-8.zip/node_modules/foreground-child/index.js:63:22)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v20.8.0
@loynoir
Copy link
Author

loynoir commented Oct 16, 2023

workaround

  • wrap c8 ... to bash -c 'echo A && c8 ... && echo B'

Seen no stuck again, yet.

@bcoe bcoe added bug help wanted Issue is well defined but needs assignment labels Oct 25, 2023
@loynoir
Copy link
Author

loynoir commented Nov 11, 2023

Even with bash -c 'echo A && c8 ... && echo B', node.js v20.8.0 sometimes still get dead loop.

Update node.js to v21.1.0, seems no problem, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Issue is well defined but needs assignment
Projects
None yet
Development

No branches or pull requests

2 participants