Convert Azure module to pull azure ip ranges from MS #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyePulp
commented
Jan 16, 2018
EyePulp
commented
- remove old data file
- update tests to allow for new Azure IPs
- fix bug in Azure's transform function that limited it to only listing the first Region in the xml
- extend the test timeout to allow for the download time Azure files need
- remove old data file - update tests to allow for new Azure IPs - fix bug in Azure's transform function that limited it to only listing the first Region in the xml - extend the test timeout to allow for the download time Azure files need
|
@bcoe Howdy - I noticed some issues with the Azure integration, and found out there's reasonably reliable (though winding) path to getting the current IP ranges from MS. Let me know if you've got tweaks you'd like me to make or if you're not interested in the changes. Thanks for the module! |
|
https://www.microsoft.com/en-us/download/confirmation.aspx?id=56519 |
|
Howdy; This PR is a bit stale. I'll go ahead and close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.