-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portuguese translation #224
Conversation
Thank you so much @codemonkey3045! Note that the following y18n keys will change with PR #222:
And I see you've already taken care of the other inconsistencies ("json" -> "JSON" and uncapitalized error messages). Awesome! If you don't get a chance to update the locale keys in |
"Implications failed:": "Implicações falharam:", | ||
"not enough arguments following: %s": "Insuficientes argumentos a seguir: %s", | ||
"invalid json config file: %s": "Arquivo de configuração em JSON esta inválido: %s", | ||
"Path to JSON config file": "Caminho para o arquivo de configuração em JSON: %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice the value here has an extra : %s
at the end (probably copied from the strings above it 😉). We'll have to remember to remove it before or during merge.
@codemonkey3045 \o/ you rock! |
Besides the additional |
@codemonkey3045 this is awesome, can't wait to unveil at braziljs, would you mind deleting |
…n the first place :(
Closing this in favor of #227. Thank you, @codemonkey3045, for the translation! 🐵 |
Benjamin Coe posted on twitter. I hope this helps and good luck :)