Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese translation #224

Closed
wants to merge 5 commits into from
Closed

Conversation

codemonkey3045
Copy link
Contributor

Benjamin Coe posted on twitter. I hope this helps and good luck :)

@nexdrew
Copy link
Member

nexdrew commented Aug 5, 2015

Thank you so much @codemonkey3045!

Note that the following y18n keys will change with PR #222:

  • "not enough arguments following: %s" -> "Not enough arguments following: %s"
  • "invalid json config file: %s" -> "Invalid JSON config file: %s"

And I see you've already taken care of the other inconsistencies ("json" -> "JSON" and uncapitalized error messages). Awesome!

If you don't get a chance to update the locale keys in pt.json, I can take care of it when we merge. Thanks again! 😃

"Implications failed:": "Implicações falharam:",
"not enough arguments following: %s": "Insuficientes argumentos a seguir: %s",
"invalid json config file: %s": "Arquivo de configuração em JSON esta inválido: %s",
"Path to JSON config file": "Caminho para o arquivo de configuração em JSON: %s",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the value here has an extra : %s at the end (probably copied from the strings above it 😉). We'll have to remember to remove it before or during merge.

@bcoe bcoe mentioned this pull request Aug 5, 2015
@bcoe
Copy link
Member

bcoe commented Aug 5, 2015

@codemonkey3045 \o/ you rock!

@nexdrew
Copy link
Member

nexdrew commented Aug 6, 2015

Besides the additional es.json file, this looks good to me. 👍

@bcoe
Copy link
Member

bcoe commented Aug 8, 2015

@codemonkey3045 this is awesome, can't wait to unveil at braziljs, would you mind deleting es.json from your commit -- we made a few edits to this language file and merged it on another branch.

@nexdrew
Copy link
Member

nexdrew commented Aug 10, 2015

Closing this in favor of #227. Thank you, @codemonkey3045, for the translation! 🐵

@nexdrew nexdrew closed this Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants