Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_modules should be removed from the repo #1116

Closed
haxwell opened this issue Jan 8, 2023 · 5 comments
Closed

node_modules should be removed from the repo #1116

haxwell opened this issue Jan 8, 2023 · 5 comments

Comments

@haxwell
Copy link

haxwell commented Jan 8, 2023

Usually, node_modules should not be checked in to the repo.

If anyone needs it, they can just run npm install.

I suggest we remove it, and add the entire node_modules/ directory to the .gitignore.

Also, we should add .idea/ to the .gitignore (intellij project files).

@pinheadmz
Copy link
Member

Please read #905

@haxwell
Copy link
Author

haxwell commented Jan 9, 2023

Noted! I understand why node_modules/ is committed to the repo.

What are your thoughts on adding .idea/ to the .gitignore?

@pinheadmz
Copy link
Member

I think that has also been brought up in other issues here but that kind of file can be ignored using a master ignore file on your own computer. For example as an OSX user I have to globally ignore DS_Store

@pinheadmz
Copy link
Member

See #686 ;-)

@haxwell
Copy link
Author

haxwell commented Jan 12, 2023

Great tip!

@haxwell haxwell closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants