Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siphash: fix message length byte during compression #1

Merged
merged 2 commits into from
Dec 31, 2017
Merged

siphash: fix message length byte during compression #1

merged 2 commits into from
Dec 31, 2017

Conversation

tuxcanfly
Copy link
Member

@tuxcanfly tuxcanfly commented Dec 13, 2017

Fixes a missing step in siphash during compression which was returning wrong hash result.

  • Fix native implementation
  • Address test failures.

@tuxcanfly tuxcanfly changed the title Fix siphash 2-4 bug siphash: fix message length byte during compression Dec 14, 2017
The last byte of f0 should be set to null bytes ending
with a byte encoding of the message length. Fixed.
Also added test vectors for siphash 64.
@chjj chjj merged commit 553d859 into bcoin-org:master Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants