Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to play VP on devcards #280

Closed
maxkonrad opened this issue Jul 14, 2024 · 3 comments
Closed

Not able to play VP on devcards #280

maxkonrad opened this issue Jul 14, 2024 · 3 comments

Comments

@maxkonrad
Copy link

maxkonrad commented Jul 14, 2024

    # Dev Card Plays
    PLAY_KNIGHT_CARD = "PLAY_KNIGHT_CARD"  # value is None
    PLAY_YEAR_OF_PLENTY = "PLAY_YEAR_OF_PLENTY"  # value is (Resource, Resource)
    PLAY_MONOPOLY = "PLAY_MONOPOLY"  # value is Resource
    PLAY_ROAD_BUILDING = "PLAY_ROAD_BUILDING"  # value is None

Here at the enums part of catanatron_core I couldn't see PLAY_VICTORY_POINT or such a naming. Why there isn't one?

@maxkonrad
Copy link
Author

And if this is a bug can I commit it? this is a good first issue and it will be my first open source contribution.

@bcollazo
Copy link
Owner

Hey @maxkonrad thanks for the interest! I think there isn't one because one doesn't really get to "play" the Victory Point per-se... just by virtue of having it, its "being played" if that makes sense. That is, the game is already keeping track of "public victory points" and "actual victory points" behind the scenes, should that should take them into account!

@maxkonrad
Copy link
Author

Oh I see, sorry for this. Thanks so much! I think this issue can be closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants