Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to format based on package.json #30

Closed
bcomnes opened this issue Aug 5, 2015 · 5 comments
Closed

Decide how to format based on package.json #30

bcomnes opened this issue Aug 5, 2015 · 5 comments

Comments

@bcomnes
Copy link
Owner

bcomnes commented Aug 5, 2015

💧 Shower thought: What if this plugin decided on which linter to use based on package.json?

Originally I pondered adding a formatter field to package.json, but we don't need that. It should be some kind of dependency for the project using it which essentially offers up consent to autoformatting.

  • This would solve our pathing issues
  • We could use formatters that follow the same interface by keeping a static list
  • Autoformatting would disable automatically an appropriate formatter is not found in the project root package.json.

The goal here is to eliminate busy work enabling and disabling linters when they differ between projects. Has this been a problem for anyone else?

@Flet
Copy link
Collaborator

Flet commented Aug 5, 2015

Yeah I've done the dance between standard and semistandard and its a little tiresome... This is a good idea!

How can it be done reliably?

@bcomnes
Copy link
Owner Author

bcomnes commented Aug 5, 2015

Re-implement package.json discovery in python based on project folders (or shell out to JS)? It might get a bit logically harry but I think we can manage it.

No package.json you ask? Why are you developing js without a package.json 😈

But seriously, in that case Leave the keyboard shortcuts/pallet commands active with a command pallet formatter selector maybe?

@Flet
Copy link
Collaborator

Flet commented Aug 5, 2015

What would be the indicator in package.json that something is standard or semistandard or doublestandard? :)

@bcomnes
Copy link
Owner Author

bcomnes commented Aug 6, 2015

The indicator would be that it has one of those packages installed and saved to its dependency list.

@bcomnes
Copy link
Owner Author

bcomnes commented Oct 24, 2015

Closing in favor of #35

@bcomnes bcomnes closed this as completed Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants