Adjust tests

lib/builder.js

@@ -92,7 +92,7 @@ function collectKeys (key, arrayOfResults) {
 
   for (const result of arrayOfResults) {
     const value = result[key]
-    collection.push(value)
+    if (value) collection.push(value)
     delete result[key]
   }
 

package.json

@@ -95,7 +95,8 @@
   },
   "standard": {
     "ignore": [
-      "test-cases/build-errors/src/**/*.js"
+      "test-cases/build-errors/src/**/*.js",
+      "test-cases/page-build-errors/src/**/*.js"
     ]
   },
   "files": [

test-cases/build-errors/index.test.js

@@ -20,15 +20,12 @@ tap.test('build-errors', async (t) => {
     const results = await siteUp.build()
     t.notOk(results, 'Build should fail, and not generate results')
   } catch (err) {
-    t.match(err.message, /Build finished but there were errors/, 'Should have an error message about a filed build.')
+    t.match(err.message, /Prebuild finished but there were errors/, 'Should have an error message about a filed build.')
     t.ok(Array.isArray(err.errors), 'Should have an array of errors')
 
-    const pageError = err.errors.find(err => err.message.includes('Error building page'))
     const cssError = err.errors.find(err => err.message.includes('Error building css'))
     const jsError = err.errors.find(err => err.message.includes('Error building JS clients'))
 
-    t.ok(pageError, 'Should include a page build error')
-    t.ok(pageError.cause, 'Should include an error cause')
     t.ok(cssError, 'Should include a css build error')
     t.ok(cssError.cause, 'Should include an error cause')
     t.ok(jsError, 'Should include a js client build error')

test-cases/page-build-errors/index.test.js

@@ -0,0 +1,31 @@
+import tap from 'tap'
+import desm from 'desm'
+import { Siteup } from '../../index.js'
+import * as path from 'path'
+import rimraf from 'rimraf'
+import { promisify } from 'util'
+
+const __dirname = desm(import.meta.url)
+const rimrafP = promisify(rimraf)
+
+tap.test('build-errors', async (t) => {
+  const src = path.join(__dirname, './src')
+  const dest = path.join(__dirname, './public')
+  const cwd = __dirname
+  const siteUp = new Siteup(src, dest, cwd)
+
+  await rimrafP(dest)
+
+  try {
+    const results = await siteUp.build()
+    t.notOk(results, 'Build should fail, and not generate results')
+  } catch (err) {
+    t.match(err.message, /Build finished but there were errors/, 'Should have an error message about a filed build.')
+    t.ok(Array.isArray(err.errors), 'Should have an array of errors')
+
+    const pageError = err.errors.find(err => err.message.includes('Error building page'))
+
+    t.ok(pageError, 'Should include a page build error')
+    t.ok(pageError.cause, 'Should include an error cause')
+  }
+})

test-cases/page-build-errors/src/README.md

@@ -0,0 +1 @@
+README.md

test-cases/page-build-errors/src/a-working-page/README.md

@@ -0,0 +1,3 @@
+# A working page
+
+Just some working markdown

test-cases/page-build-errors/src/client.js

@@ -0,0 +1 @@
+console.log('hi')

test-cases/page-build-errors/src/page.js

@@ -0,0 +1,7 @@
+export default () => /* html */`
+<div>Hello this is a JS page</div>
+`
+
+// Some garbled JS syntax
+// eslint-disable-next-line
+fdsf dsf fdsaf;

test-cases/page-build-errors/src/style.css

@@ -0,0 +1,3 @@
+.some-class {
+  background: blue;
+}