Fix interference #22
Closed
Fix interference #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
commit 8d063f0 'Skipping frames when signal < CCA_THRESHOLD' could skip the set_interference_duration() call also even though the function works when the signal is weaker than CCA_THRESHOLD. So move it to after the function call. Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
set_interference_duration() and send_cloned_frame_msg() are each called twice. So aggregate them to one. Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Because CCA_THRESHOLD is checked by trailing code. Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
The interference simulation introduced by commit 5ba7123 'Simulate Radio wave interference' was wrongly implemented. Previously, signal strength from node A to B was calculated and wrongly accumlated to interference duration of "A to all". This patch fix it to "A to B". Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.