Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the regex in
$f3->route()
is a bit too permissive for aliases. It allows nearly all characters, in particular dots, while it should stick to the\w
range.What drew my attention is an issue for my f3-access plugin where the user has defined aliases with dots: xfra35/f3-access#4
Additionally, there's that
?
after@
which seems superfluous to me. But I could be missing something.