Throw error on mapper update/erase if the table has no primary key #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i welcome this pr, although i can imagine of config-tables with only one row in it, so that this breaks compatibility. |
|
I'm actually for this change, as I also had a similar adventure once before. If there are edge-cases for 1-row tables, we'll find a solution for it. I could imagine to put this behaviour into a mass-update method, so that you can batch-update all or some records at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had a bad experience today with the
DB\SQL\Mapper->save()executing anUPDATEon the whole table instead of a single row. I realized that the table had a unique key but no primary key... and the framework did nothing to prevent the massive undesiredUPDATE.Hence this proposal to throw an error on
update/erase()if no PK can be found.