Minify generates minified content twice when not given an explicit path.

[phellamon]

FFF: version 3.6
File: Web.php
Function: minify()

To reproduce: echo minify(["your_javascript_file.js"]);

Result: the content of the file is minified twice and concatenated. ( ... causing javascript to run twice once received by the browser ...)

Cause: line 587: $path=$fw->get('UI').';./'; results in $path being "./;./;" causing the foreach statement on line 588 to run twice for the "./" directory.

Expected result: the minified content should be returned only once.

Solution: remove doubles on the result of $fw->split($path,FALSE)

Workaround: call minify() with an explicit "./" path parameter.

[dduers]

I feel like there is something broken now (F3 3.7.0) ... I pass a comma separated list of files to the minifyer and only the first file is included. Am I doing wrong? Under F3 3.6.5 it had worked.

echo \Web::instance()->minify("file1.js,file2.js,file3.js", null, true, 'js/');

[leonardfischer]

Hey @dduers I notices something similiar earlier today and opened an issue: f3-factory/fatfree-core#289

[dduers]

Hey @dduers I notices something similiar earlier today and opened an issue: bcosca/fatfree-core#289

You already closed your issue?

[leonardfischer]

Hey @dduers
I didn't close my issue - I think what you are seeing is "this" issue being referenced by my comment ;)

[dduers]

@leonardfischer yes, ok

[ikkez]

It's already solved here. please checkout latest dev version... will release a patch version soon