-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_ #673
Comments
I laready proposed this change (with a centralized function, maybe it would be better to use a class). refused. |
👍 |
@stehlo It is possible that |
|
|
A
An empty |
The |
it is less important in my humble opinion. What we need is to start a session when necessary (lazily) & avoid multiple calls to session_start. |
I don't think it is insane to move to php 5.4 we have all be running f3 on On Thu, Sep 4, 2014 at 1:41 AM, boussou notifications@github.com wrote:
|
yeah php 5.4 is nice. @boussou: well that is indeed a good point. |
Frankly, there is no urge to stop beeing compatible with 5.3. |
You kind of just contradicted yourself, but obviously I just said I use php 5.3 is probably going to be standard for another year at least, so I On Sep 4, 2014 10:25 AM, "boussou" notifications@github.com wrote:
|
Considering the end of PHP 5.3's lifecycle has been announced, we can start planning for development of a 5.4 branch and backport whatever is feasible. |
In the meanwhile, maybe we could replace every call to
|
👍 |
👍 for >= PHP 5.4 |
"cause premature interruption of this database operation, due to the error being thrown". @stehlo Can you explain further how exactly this causes an Error? Docs and my testing show multiple calls to session_start() causing non fatal E_NOTICE errors (unless of course you have PHP configured such that E_NOTICE is fatal), and returns true if a session exists or a new sessions is started, or false if not. |
@stehlo Your right I don't understand. Could you please explain the error the change you requested fixes more clearly? Your response is appreciated. |
Guys, let's keep this discussion civil. This request has been considered, but it is tabled for version 4 of the framework due to the PHP5.4 feature that is known to settle this issue once and for all. The suggested fix in my opinion is really just a workaround due to PHP5.3's language deficiency. |
@sam-at-github to answer your question, I can see that the error reporting changed from 3.3.0 to 3.4.0: //3.3.0
error_reporting(E_ALL|E_STRICT);
//3.4.0
error_reporting((E_ALL|E_STRICT)&~E_NOTICE); That probably explains the difference (E_NOTICE ignored in 3.4.0). |
As @bcosca introduced PHP 5.4 features to |
_
The text was updated successfully, but these errors were encountered: