Skip to content

Commit

Permalink
wip In perl.js VERSION var for module.exports
Browse files Browse the repository at this point in the history
also updated CONTRIBUTING docs for Pushing changes.
  • Loading branch information
bcowgill committed Mar 18, 2021
1 parent 2d6674e commit 4efc0e9
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@ Review the test coverage output to ensure you’ve tested whatever has been adde

## Releasing

Due to current use of an old Git version 1.9.1 and [npm 7+ bug](https://github.com/npm/cli/issues/2871) we run the *npm version* command with *--no-git-version-tag* and leave the *git* operations to *pre-version.sh* and *version.sh* scripts.
### Pushing

After you push changes you need to check that the [TravisCI build](https://travis-ci.org/github/bcowgill/perljs) succeeds.

### Version Bump

Due to current use of an old Git version 1.9.1 and [npm 7+ bug](https://github.com/npm/cli/issues/2871) we run the *npm version* command with *--no-git-version-tag* and leave the *git* operations to *pre-version.sh* and *version.sh* scripts.

You can begin a version release via:

```sh
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ A license with no conditions whatsoever which dedicates works to the public doma

## TODO

Change prepublish script to prepublishOnly so to avoid being balled when npm install on TravisCI
Add Badges for Stylelint etc
wip Submit CSS dark changes to nyc/istanbul project and/or release as nyc-html-dark npm package
Fix up mocha dark CSS for latest mocha release 8.x in ~/bin/mocha-dark
Expand Down
2 changes: 2 additions & 0 deletions env.local
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@
set +x
nvm use
git --version
nvm --version
node --version
npm --version
pnpm --version

# Versions this last worked with:
# \git --version git version 1.9.1
# \nvm --version 0.31.4
# \node --version v12.19.0
# \npm --version 7.5.6
# \pnpm --version 5.18.6
Expand Down
2 changes: 2 additions & 0 deletions lib/perl.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@
var perljs = { name: 'perljs' }

perljs.version = '0.3.7'
perljs.VERSION = perljs.version // for module exports compatability

/**
@property {object} _console Console logging object to use for warnings.
default to the console.
Expand Down

0 comments on commit 4efc0e9

Please sign in to comment.