Store logs in $HOME/.unison, rather than polluting $HOME

[LocutusOfBorg]

Hello, Ubuntu applied a similar patch some years ago, to avoid HOMEDIR being polluted with many conf files

Description: Change logfile location
 ... by prepending .unison to name of logfile in ubase/trace.ml
Author: Tan Rui Boon <ruiboon@gmail.com>
Bug-Debian: http://bugs.debian.org/484997
Bug-Ubuntu: https://bugs.launchpad.net/bugs/234365
Forwarded: no
Last-Update: 2011-09-10

--- a/ubase/trace.ml
+++ b/ubase/trace.ml
@@ -113,10 +113,10 @@ let logging =

 let logfile =
   Prefs.createFspath "logfile"
-    (Util.fileInHomeDir "unison.log")
+    (Util.fileInHomeDir ".unison/unison.log")
     "!logfile name"
     "By default, logging messages will be appended to the file
-     \\verb|unison.log| in your HOME directory.  Set this preference if
+     \\verb|unison.log| in your .unison directory.  Set this preference if
      you prefer another file."

 let logch = ref None

is it possible to upstream this change? thanks!

[gdt]

A PR would help; seems like a reasonable change.

[bcpierce00]

Seems reasonable to me too...

…

On Sep 14, 2020, at 8:27 AM, Greg Troxel ***@***.***> wrote: A PR would help; seems like a reasonable change. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#318 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVQQC5IZ7SQLLCKSN2OHFDSFYD47ANCNFSM4KWUVJLA>.

[glondu]

Note that the UNISON variable should be honored, maybe use Util.fileInUnisonDir instead?

[LocutusOfBorg]

Sorry but I don't speak ocaml since lots of time, can anybody please do the pull request?

[glondu]

can anybody please do the pull request?

I will.