Listen on multiple sockets when needed #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code assumed there is always only one listening socket. That one socket happened to be the first one that was successfully created and bound. Usually, that would be IPv4 but it could just as well have been IPv6. This patch enables creating multiple listening sockets (for vast majority of cases it is expected to be 2) and accepting clients on all of these sockets. Like before, a single client at a time is served.
|
As usual, I would really love to see a code review or test report (from other than the submitter, who I am confident has tested). But will time out on that and merge anyway after a while if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #562 for background.
This is the first attempt at it, and may be sufficient. Listen and accept on multiple sockets if multiple addresses are returned by
getaddrinfo.There are some indentation changes,
diff -wmay help when reviewing.Fixes #562