-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus state not stylized for toggle button #40 #54
Merged
dmitriy-bizyaev
merged 2 commits into
master
from
Be-Smart-focus-state-not-stylized-for-ToggleButton-#40
Nov 10, 2017
Merged
Focus state not stylized for toggle button #40 #54
dmitriy-bizyaev
merged 2 commits into
master
from
Be-Smart-focus-state-not-stylized-for-ToggleButton-#40
Nov 10, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmaltsev
force-pushed
the
Be-Smart-focus-state-not-stylized-for-ToggleButton-#40
branch
from
October 26, 2017 03:42
2009f16
to
d172759
Compare
nickmaltsev
force-pushed
the
Be-Smart-focus-state-not-stylized-for-ToggleButton-#40
branch
from
October 26, 2017 15:29
d172759
to
c7677ba
Compare
netmenya
changed the title
Be smart - focus state not stylized for toggle button #40
Focus state not stylized for toggle button #40
Oct 27, 2017
dmitriy-bizyaev
suggested changes
Oct 27, 2017
theme: themeFromProvider, | ||
}) => { | ||
const theme = extractThemeOrDefault(themeFromProvider); | ||
|
||
const hoverOffset = | ||
theme.reactackle.components.toggleButton.toggleThumb.hoverOffset; | ||
|
||
const offset = hover && !disabled ? getValueString(hoverOffset) : 0, | ||
const offset = (hover || focus) && !disabled | ||
? getValueString(hoverOffset) : 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
nickmaltsev
force-pushed
the
Be-Smart-focus-state-not-stylized-for-ToggleButton-#40
branch
from
October 30, 2017 06:20
20351cb
to
c9ad685
Compare
nickmaltsev
force-pushed
the
Be-Smart-focus-state-not-stylized-for-ToggleButton-#40
branch
from
October 30, 2017 06:33
c9ad685
to
6963638
Compare
dmitriy-bizyaev
approved these changes
Nov 10, 2017
dmitriy-bizyaev
deleted the
Be-Smart-focus-state-not-stylized-for-ToggleButton-#40
branch
November 10, 2017 13:12
d-slabunov
pushed a commit
to d-slabunov/reactackle
that referenced
this pull request
Sep 12, 2019
…tylized-for-ToggleButton-#40 Focus state not stylized for toggle button bcrumbs#40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreate #49, because it's opened from his fork