Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus state not stylized for toggle button #40 #54

Merged

Conversation

nickmaltsev
Copy link
Contributor

recreate #49, because it's opened from his fork

@nickmaltsev nickmaltsev force-pushed the Be-Smart-focus-state-not-stylized-for-ToggleButton-#40 branch from 2009f16 to d172759 Compare October 26, 2017 03:42
@nickmaltsev nickmaltsev force-pushed the Be-Smart-focus-state-not-stylized-for-ToggleButton-#40 branch from d172759 to c7677ba Compare October 26, 2017 15:29
@netmenya netmenya changed the title Be smart - focus state not stylized for toggle button #40 Focus state not stylized for toggle button #40 Oct 27, 2017
theme: themeFromProvider,
}) => {
const theme = extractThemeOrDefault(themeFromProvider);

const hoverOffset =
theme.reactackle.components.toggleButton.toggleThumb.hoverOffset;

const offset = hover && !disabled ? getValueString(hoverOffset) : 0,
const offset = (hover || focus) && !disabled
? getValueString(hoverOffset) : 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 92.881% when pulling 20351cb on Be-Smart-focus-state-not-stylized-for-ToggleButton-#40 into 452b3fc on master.

@nickmaltsev nickmaltsev force-pushed the Be-Smart-focus-state-not-stylized-for-ToggleButton-#40 branch from 20351cb to c9ad685 Compare October 30, 2017 06:20
@nickmaltsev nickmaltsev force-pushed the Be-Smart-focus-state-not-stylized-for-ToggleButton-#40 branch from c9ad685 to 6963638 Compare October 30, 2017 06:33
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 92.881% when pulling 6963638 on Be-Smart-focus-state-not-stylized-for-ToggleButton-#40 into d484f22 on master.

@dmitriy-bizyaev dmitriy-bizyaev merged commit 59c62cd into master Nov 10, 2017
@dmitriy-bizyaev dmitriy-bizyaev deleted the Be-Smart-focus-state-not-stylized-for-ToggleButton-#40 branch November 10, 2017 13:12
d-slabunov pushed a commit to d-slabunov/reactackle that referenced this pull request Sep 12, 2019
…tylized-for-ToggleButton-#40

Focus state not stylized for toggle button bcrumbs#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants