reactackle-icons #56
Merged
reactackle-icons #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriy-bizyaev
suggested changes
Nov 2, 2017
| /** Set icon type */ | ||
| type: PropTypes.oneOf(['font-awesome', 'library']), | ||
| }), | ||
| icon: PropTypes.node, |
There was a problem hiding this comment.
Change prop type to PropTypes.element
| @@ -139,14 +137,14 @@ const kindProps = ({ colorScheme, outlined, theme: themeFromProvider }) => { | |||
| const borderWidth = theme.reactackle.components.button.borderWidth; | |||
| const borderStyle = theme.reactackle.components.button.borderStyle; | |||
|
|
|||
| return css` | |||
| return css` | |||
There was a problem hiding this comment.
Remove trailing spaces
| size: bmodule(2), | ||
| imgSize: null, | ||
| // eslint-disable-next-line react/display-name | ||
| src: () => <IconCheck size="custom" color="currentColor" />, |
There was a problem hiding this comment.
src must be a react element, not a component
| height: null, | ||
| imgSize: 24, | ||
| // eslint-disable-next-line react/display-name | ||
| iconSrc: () => <IconCross size="custom" color="inherit" />, |
There was a problem hiding this comment.
iconSrc must be a react element, not a component
| }, | ||
| iconTextSpacing: bmodule(0.5), | ||
| // eslint-disable-next-line react/display-name | ||
| src: () => <IconArrowDropDown size="custom" color="inherit" />, |
There was a problem hiding this comment.
src must be a react element, not a component
| @@ -496,8 +486,9 @@ class _TextField extends Component { | |||
| dense={this.props.dense} | |||
| fullWidth={this.props.fullWidth} | |||
| colorScheme={this.props.colorScheme} | |||
| type="svg" | |||
There was a problem hiding this comment.
Remove props IconInnerStyled doesn't support
| @@ -18,7 +18,7 @@ const propTypes = { | |||
| /** | |||
| * Add icon behind textfield | |||
| */ | |||
| iconOuter: PropTypes.string, | |||
| iconOuter: PropTypes.object, | |||
There was a problem hiding this comment.
iconOuter is PropTypes.element
| @@ -34,7 +34,7 @@ const propTypes = { | |||
| /** | |||
| * Add icon behind textfield | |||
| */ | |||
| iconOuter: PropTypes.string, | |||
| iconOuter: PropTypes.object, | |||
There was a problem hiding this comment.
iconOuter is PropTypes.element
| @@ -15,7 +15,7 @@ const propTypes = { | |||
| colorScheme: PropTypes.oneOf(['neutral', 'error', 'success']), | |||
| labelPosition: PropTypes.oneOf(['top', 'side']), | |||
| slidingLabel: PropTypes.bool, | |||
| iconOuter: PropTypes.string, | |||
| iconOuter: PropTypes.object, | |||
There was a problem hiding this comment.
iconOuter is PropTypes.element
| /* eslint-disable react/display-name */ | ||
| clearingIcon: () => <IconCross size="custom" color="inherit" />, | ||
| passwordIconShow: () => <IconEye size="custom" color="inherit" />, | ||
| passwordIconHide: () => <IconEyeClosed size="custom" color="inherit" />, |
There was a problem hiding this comment.
elements, not components!
dmitriy-bizyaev
approved these changes
Nov 3, 2017
d-slabunov
pushed a commit
to d-slabunov/reactackle
that referenced
this pull request
Sep 12, 2019
reactackle-icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.