Test updates for vectors from other implementations #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjschuck
force-pushed
the
test-updates
branch
3 times, most recently
from
fa8551d
to
69f896f
Compare
Keeping the one at the bottom because that’s where Openwall has it.
These were deleted in #182, but are a part of the Openwall test vectors. They’re important because they’re actually making the string longer than 72 characters, which is the test that the vector is going for.
This should actually cross-check implementations — the Java vectors should pass when using the C implementation, and the C vectors should pass when using the Java implementation.
tjschuck
force-pushed
the
test-updates
branch
from
69f896f
to
0a9e5c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly more details in each commit's full commit message, but:
32dac7d — Update blowfish imprementation to latest version #182 duplicated a vector.
a2835b0 — Update blowfish imprementation to latest version #182 deleted some meaningful characters from the Openwall implementation that these vectors came from.
45bb290 — add vectors from the Java implementation as well.