Remove explicit support for Rubies 1.8 and 1.9 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjschuck
added a commit
that referenced
this pull request
Nov 15, 2018
REE is a 1.8-compatible Ruby, so drop it along with the rest of the 1.8s and 1.9s in #185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've repeatedly threatened, I would keep supporting 1.8 and 1.9 until it became too difficult to do so.
Well, that time has come. I've sunk too many hours into these at this point, and the 4.0 release we're heading towards is a good time to drop explicit support.
They're still implicitly supported in the sense that there's not necessarily anything stopping a user from figuring out how to get them up and running (all of the difficulty is environmental, not bcrypt-ruby's code — compilers and OpenSSLs and CI and installing the Rubies themselves), but I'm not going to let 1.8 and 1.9 test failures be blocking anymore.