Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install 1.3.1 on Python 3.6 #37

Closed
ephracis opened this issue May 19, 2019 · 4 comments
Closed

Cannot install 1.3.1 on Python 3.6 #37

ephracis opened this issue May 19, 2019 · 4 comments
Labels

Comments

@ephracis
Copy link

Noticed you released a new version a couple of hours ago. It broke my CI which worked fine on 1.3.0. It still works on Python 2, though. Here is what I get:

[root@5005dfa6c983 /]# pip3 --version
pip 19.1.1 from /usr/local/lib/python3.6/site-packages/pip (python 3.6)
[root@5005dfa6c983 /]# pip3 install -U warlock
Collecting warlock
  Using cached https://files.pythonhosted.org/packages/77/c6/48ad0aac045a477546709c952d12511f7f2291096caa4e6a3f558369f37d/warlock-1.3.1.tar.gz
    ERROR: Complete output from command python setup.py egg_info:
    ERROR: Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-ocjuyama/warlock/setup.py", line 35, in <module>
        long_description=read("README.md"),
      File "/tmp/pip-install-ocjuyama/warlock/setup.py", line 28, in read
        return fp.read()
      File "/usr/lib64/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 10: ordinal not in range(128)
    ----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-ocjuyama/warlock/

When I add warlock==1.3.0 to my requirements.txt it works. There's something wrong with the new release.

@janw janw added the bug label May 19, 2019
@janw
Copy link
Contributor

janw commented May 19, 2019

Hey @ephracis, sorry about that. Could you, for starters, set the following variables in the environment of your CI pipeline?

export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
export LANGUAGE=en_US.UTF-8

The error is most likely rooted in an incorrectly set up utf-8 environment. If that succeeds I'll be able to provide a fix in the project.

@janw
Copy link
Contributor

janw commented May 20, 2019

I replicated the error locally by forcing ascii encoding on the files, so this is indeed the environment not being set up for utf-8. While I still think you @ephracis should check why that is the case (other things apart from Warlock's setup.py might break in the future), I will provide a fix to this particular issue in 1.3.2 within the hour.

janw added a commit that referenced this issue May 20, 2019
No actual changes from 1.3.2 are merged as the touched files (and issue)
are no longer present. See #37
@freddebacker
Copy link

freddebacker commented May 20, 2019

My install is broken too for python2.7. (EDIT: see #41)

  Downloading https://files.pythonhosted.org/packages/7e/9b/648ceb3bc527e821c04d69f14facb0655268288ac7d8d6aa3a026c3316ea/warlock-1.3.2.tar.gz
    ERROR: Complete output from command python setup.py egg_info:
    ERROR: Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-yl9AL5/warlock/setup.py", line 37, in <module>
        long_description=read("README.md"),
      File "/tmp/pip-install-yl9AL5/warlock/setup.py", line 28, in read
        os.path.join(os.path.dirname(__file__), fname), "r", encoding="utf-8"
    TypeError: 'encoding' is an invalid keyword argument for this function
    ----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-yl9AL5/warlock/

@ephracis
Copy link
Author

I just tried to run pip3 install -U warlock and it worked fine. Got 1.3.2 so I guess your updated fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants