Added Icon.system for SF Symbols #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcylin
reviewed
Jan 9, 2020
There was a problem hiding this comment.
Thanks much for the pull request! The CI build fails because init(systemName:) requires iOS 13+. It'd be better to add the API compatibility.
Co-Authored-By: Cheng-Yao Lin <b.cylin@gmail.com>
Co-Authored-By: Cheng-Yao Lin <b.cylin@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #41 +/- ##
===========================================
- Coverage 93.94% 93.73% -0.22%
===========================================
Files 14 14
Lines 314 319 +5
===========================================
+ Hits 295 299 +4
- Misses 19 20 +1
|
|
I see now that the code coverage is failing. I'll take a look at fixing that in a little bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an Icon type that pulls from
UIImage(systemName:)versusUIImage(named:).