Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install through bloom fails if setuptools is upgraded #13

Open
bhung-bdai opened this issue Nov 7, 2023 · 0 comments
Open

Install through bloom fails if setuptools is upgraded #13

bhung-bdai opened this issue Nov 7, 2023 · 0 comments
Assignees

Comments

@bhung-bdai
Copy link
Collaborator

bhung-bdai commented Nov 7, 2023

Hey,

Currently setuptools throws a deprecation warning if any version checks that are called through setuptools's version check are not compatible. It will still run though:
image
However, in released versions of setuptools that are available and installed through ros-humble-desktop, setuptools is upgraded to a point where it no longer accepts valid versions. See the following:
image

This is an issue with bloom specifically since bloom expects a MacOS (see the error above):
image
inside the file /dist-packages/bloom/logging.py. This causes the Debian build to fail if setuptools has too high of a version, as previous versions of setuptools simply throw a warning instead of raising an error.

I think a simple solution for now is to pin the Docker with setuptools being at a lower version and to include a comment in the README about it, unless we can find a different tool besides bloom to build the debian.

amessing-bdai pushed a commit that referenced this issue Feb 9, 2024
* Rework continuous deployment job

- Always build in containers
- Fix bundle aliasing

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>

* Fix bad syntax

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>

---------

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants