[SW-213] Stopped ignoring FrameTreeSnapshot proto #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amessing-bdai
force-pushed
the
amessing/frametreesnapshot
branch
from
d31a00d
to
7cc58f3
Compare
jbarry-bdai
reviewed
Jun 16, 2023
|
It previous existed, so wasn't created or editted. We were simply ignoring it as a parameter https://github.com/bdaiinstitute/bosdyn_msgs/blob/amessing/frametreesnapshot/CMakeLists.txt#L379 |
amessing-bdai
force-pushed
the
amessing/frametreesnapshot
branch
from
7cc58f3
to
a2a4464
Compare
jbarry-bdai
approved these changes
Jun 16, 2023
|
Yes, I’ve already rebuilt the Debian. About to test it then will make the
release
…On Fri, Jun 16, 2023 at 4:21 PM jbarry-bdai ***@***.***> wrote:
***@***.**** approved this pull request.
We also need to create a new release for this... see the README.
—
Reply to this email directly, view it on GitHub
<#5 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A64FCU6TRTTPPBSEKYLEYIDXLS53LANCNFSM6AAAAAAZJRV6SA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.