Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] Clarify prebaked docstring #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ggoretkin-bdai
Copy link
Contributor

No description provided.

Co-authored-by: mhidalgo-bdai <144129882+mhidalgo-bdai@users.noreply.github.com>
@ggoretkin-bdai
Copy link
Contributor Author

I later noticed that there is basically the same description here:

prebaked: whether to include an implicit main node in the scope graph or not,

@mhidalgo-bdai
Copy link
Contributor

I later noticed that there is basically the same description here:

Very similar but not exactly the same.

@ggoretkin-bdai
Copy link
Contributor Author

@mhidalgo-bdai should the descriptions of prebaked in each case (ROSAwareScope and ROSAwareProcess) be the same? If not, perhaps we can highlight the difference.

@mhidalgo-bdai
Copy link
Contributor

@ggoretkin-bdai descriptions are different already, but by omission. If it helps, we can definitely mention each other and make that difference explicit.

@amessing-bdai
Copy link
Collaborator

@ggoretkin-bdai descriptions are different already, but by omission. If it helps, we can definitely mention each other and make that difference explicit.

@mhidalgo-bdai We should make the difference explicit. Otherwise, I doubt this will be the last time there is confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants