Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to pymysql #40

Merged
merged 1 commit into from Sep 5, 2016
Merged

Fallback to pymysql #40

merged 1 commit into from Sep 5, 2016

Conversation

tebeka
Copy link
Contributor

@tebeka tebeka commented Sep 5, 2016

This allows torndb to fallback to pymysql which is pure Python and does not require compilation or mysql headers.

@bdarnell bdarnell merged commit e7bd428 into bdarnell:master Sep 5, 2016
@bdarnell
Copy link
Owner

bdarnell commented Sep 5, 2016

Thanks! But be aware that this package is not maintained any more and I don't plan to make more changes to it.

@tebeka
Copy link
Contributor Author

tebeka commented Sep 5, 2016

Thanks! I know but I have some legacy code I'd like to support.

Any chance there will be a new release to pypi?

@bdarnell
Copy link
Owner

Does this work for you? When I try to import torndb with pymysql instead of MySQLdb, I get

python -c 'import torndb'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/torndb/lib/python3.5/site-packages/torndb.py", line 266, in <module>
    CONVERSIONS[field_type] = [(FLAG.BINARY, str)] + CONVERSIONS[field_type]
TypeError: can only concatenate list (not "function") to list

@tebeka
Copy link
Contributor Author

tebeka commented Feb 26, 2017

I see what you mean. It's been a while since I've worked on that project and I don't have access to the actuall working patch.

I've added a check to do that code only on MySQLdb and not on pymysql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants