Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the result content at first #23

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Conversation

hashcc
Copy link

@hashcc hashcc commented Mar 11, 2022

Closes #15

Objective

For users to find the query result much faster.

What to change

  1. Change the order of content, result at first
  2. Limit max height of result to 500px

1. Change the order of content, result at first

Before

  1. Title & description
  2. SQL
  3. Chart
  4. Result
  5. Data source

After

  1. Title & description
  2. Chart
  3. Result
  4. SQL
  5. Data source

2. Limit max height of result to 500px

  • Even if the result is too long (over 1000 column..), users can easily view the SQL because we limited height of result content to 500px
  • Header of result table is sticked to top if scroll. So the users can find what each cells mean everywhere.

Screenshot

@morishin Please review!

Copy link
Collaborator

@morishin morishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューがめちゃくちゃ遅くなってしまってすみません!仕様は LGTM です。実装については1点 IMO を書いたのでご検討いただけると 🙏

position: sticky;
top: 0;
background-color: white;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMO] css modules を書くよりも ChakraUI のインターフェースに従ってこんな感じで書く方が書きやすい&読みやすいと思いました 💭

<Box overflowY="auto" maxHeight="500px">
  <Table variant="striped" size="sm" colorScheme="blackAlpha">
    ...
    <Thead position="sticky" top={0} bgColor="white">

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど。Chakra UIを利用して、仰るように修正しました ✅
#23

@hashcc
Copy link
Author

hashcc commented Jul 10, 2022

@morishin 上記で問題なければマージお願いします 🙏

@morishin morishin merged commit 38fc12a into bdash-app:main Jul 11, 2022
@morishin
Copy link
Collaborator

ありがとうございます!マージしました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL文より結果を先に表示してほしい
2 participants