-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send embedded image of color palette to bypass Discords caching #2
Comments
The fix is really simple, just need to change this: message.reply('Here is your palette: https://coolors.co/' + colorString) to this: message.reply('Here is your palette: https://coolors.co/' + colorString, {
embed: {
image: {
url: 'https://coolors.co/export/png/' + colorString
}
}
}) The only problem here is, that the used discord.js version in cordlr not really supports embed messages (not as reply and the method message.channel.sendEmbed doesnt exist, also you can't send an embed message with message.channel.sendMessage as second argument). I updated discord.js inside cordlr for testing purpose to the latest discord.js version (11.0.0 right now) and this fix worked fine, but with the current used discord.js version, I'm pretty sure you cant send an embed message. We really need to upgrade discord.js. |
I'll update Discord.js. Could you add an issue for that on the cordlr-cli repository? I'll take care of that. You can also send in a PR if you want to. Otherwise great one! I'll implement embeds into other modules too. |
I did bdbch/cordlr-cli#112. I'll go to bed now, maybe I can make a PR tomorrow or you are faster. |
Discord.js is updated! |
I made an PR and I reported this bug to coolors.co. They said, they gonna fix this too. |
Changed reply to embed Message to fix #2 and updated to latest color
Example URL:
https://coolors.co/export/png/FF0000-ff0000-b30000-ffbfbf-ff8080
The text was updated successfully, but these errors were encountered: