fixes error update triggering unnecessary updates

bdbch · Jul 26, 2019 · 802a2fb · 802a2fb
1 parent d9c43d0
commit 802a2fb
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/src/lib/branch/useBranch.ts b/src/lib/branch/useBranch.ts
@@ -23,15 +23,15 @@ export default function useBranch(
       branchName.length > 0
     ) {
       setLoading(true);
-      setError(null);
+      setError(undefined);
       fetch(
         `https://api.github.com/repos/${owner}/${repo}/branches/${branchName}`
       )
         .then(res => res.json())
         .then(data => {
           setLoading(false);
           setBranch(data);
-          setError(null);
+          setError(undefined);
         })
         .catch(e => {
           setLoading(false);

diff --git a/src/lib/branch/useBranches.ts b/src/lib/branch/useBranches.ts
@@ -15,13 +15,13 @@ export default function useBranches(
   useEffect(() => {
     if (repo && repo.length > 0 && owner && owner.length) {
       setLoading(true);
-      setError(null);
+      setError(undefined);
       fetch(`https://api.github.com/repos/${owner}/${repo}/branches`)
         .then(res => res.json())
         .then(data => {
           setLoading(false);
           setBranches(data);
-          setError(null);
+          setError(undefined);
         })
         .catch(e => {
           setLoading(false);

diff --git a/src/lib/release/useLatestRelease.ts b/src/lib/release/useLatestRelease.ts
@@ -14,7 +14,7 @@ export default function useLatestRelease(
 
   useEffect(() => {
     if (owner && owner.length > 0 && repo && repo.length > 0) {
-      setError(null);
+      setError(undefined);
       setLoading(true);
 
       fetch(`https://api.github.com/repos/${owner}/${repo}/releases/latest`)

diff --git a/src/lib/release/useTaggedRelease.ts b/src/lib/release/useTaggedRelease.ts
@@ -22,7 +22,7 @@ export default function useTaggedRelease(
       tag &&
       tag.length > 0
     ) {
-      setError(null);
+      setError(undefined);
       setLoading(true);
 
       fetch(

diff --git a/src/lib/repository/useCollaborators.ts b/src/lib/repository/useCollaborators.ts
@@ -15,13 +15,13 @@ export default function useCollaborators(
   useEffect(() => {
     if (repo && repo.length > 0 && owner && owner.length) {
       setLoading(true);
-      setError(null);
+      setError(undefined);
       fetch(`https://api.github.com/repos/${owner}/${repo}/collaborators`)
         .then(res => res.json())
         .then(data => {
           setLoading(false);
           setCollaborators(data);
-          setError(null);
+          setError(undefined);
         })
         .catch(e => {
           setLoading(false);

diff --git a/src/lib/repository/useForks.ts b/src/lib/repository/useForks.ts
@@ -10,13 +10,13 @@ export default function useForks(owner: string, repo: string): IForksResponse {
   useEffect(() => {
     if (repo && repo.length > 0 && owner && owner.length) {
       setLoading(true);
-      setError(null);
+      setError(undefined);
       fetch(`https://api.github.com/repos/${owner}/${repo}/forks`)
         .then(res => res.json())
         .then(data => {
           setLoading(false);
           setForks(data);
-          setError(null);
+          setError(undefined);
         })
         .catch(e => {
           setLoading(false);