Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accessibility): play with keyboard #153

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

feat(accessibility): play with keyboard #153

wants to merge 4 commits into from

Conversation

franktronics
Copy link

@franktronics franktronics commented Nov 25, 2022 •
edited

  • Add hover effect on the Title.
  • You can play with the keyboard and choose the keys.
  • There is also a popub that displays the keys used

✅ Closes: #152

Tests

  • I have run the tests of the project. pnpm test-affected

Clean Code

  • I made sure the code is type safe (no any)

@franktronics
feat: 🎸 play with keyboard
24baacd 
Add hover effect on the Title, you can play with the keyboard

✅ Closes: bdebon#152
@franktronics franktronics changed the title feat: 🎸 play with keyboard feat(accessibility): play with keyboard Nov 25, 2022
franktronics and others added 2 commits November 26, 2022 19:19
@franktronics @KGALLET
Update libs/shared/ui/src/lib/question/question.tsx
ea4b245 
Co-authored-by: Kevin Gallet <kevingallet@gmail.com>
@franktronics
Table for the keys
fb8ee32
KGALLET
KGALLET approved these changes Nov 26, 2022
View reviewed changes
Copy link

@KGALLET KGALLET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !
Approved the PR 👌🏻

@KGALLET
Copy link

KGALLET commented Nov 26, 2022 •
edited

We can also use the fireEvent method from @testing-library to test this feature

@franktronics
chore: 🤖 Play with keyboards ( add help popup)
8927fde 
I created a small pupub to indicate the keys to press

✅ Closes: bdebon#152
@franktronics franktronics reopened this Nov 28, 2022
@franktronics
Copy link
Author

@bdebon can you check it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KGALLET KGALLET Awaiting requested review from KGALLET

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Play with Keyboard
2 participants
@franktronics @KGALLET