Skip to content

feat(accessibility): play with keyboard#153

Open
franktronics wants to merge 4 commits into
bdebon:stagingfrom
franktronics:staging
Open

feat(accessibility): play with keyboard#153
franktronics wants to merge 4 commits into
bdebon:stagingfrom
franktronics:staging

Conversation

@franktronics

@franktronics franktronics commented Nov 25, 2022

Copy link
Copy Markdown
  • Add hover effect on the Title.
  • You can play with the keyboard and choose the keys.
  • There is also a popub that displays the keys used

Closes: #152

Tests

  • I have run the tests of the project. pnpm test-affected

Clean Code

  • I made sure the code is type safe (no any)

Add hover effect on the Title, you can play with the keyboard

✅ Closes: bdebon#152
@franktronics franktronics changed the title feat: 🎸 play with keyboard feat(accessibility): play with keyboard Nov 25, 2022
Comment thread libs/shared/ui/src/lib/question/question.tsx Outdated
franktronics and others added 2 commits November 26, 2022 19:19
Co-authored-by: Kevin Gallet <kevingallet@gmail.com>
@franktronics franktronics requested a review from KGALLET November 26, 2022 18:36

@KGALLET KGALLET left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !
Approved the PR 👌🏻

@KGALLET

KGALLET commented Nov 26, 2022

Copy link
Copy Markdown

We can also use the fireEvent method from @testing-library to test this feature

I created a small pupub to indicate the keys to press

✅ Closes: bdebon#152
@franktronics

Copy link
Copy Markdown
Author

@bdebon can you check it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Play with Keyboard

2 participants