Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public methods and public widgets for CustomNavigationPane #365

Closed
Arenukvern opened this issue May 22, 2022 · 0 comments · Fixed by #390
Closed

Public methods and public widgets for CustomNavigationPane #365

Arenukvern opened this issue May 22, 2022 · 0 comments · Fixed by #390
Labels
enhancement New feature or request

Comments

@Arenukvern
Copy link

Arenukvern commented May 22, 2022

Is your feature request related to a problem? Please describe.
First - thank you very much for the awesome library!

A problem:

NavigationPane has an option to provide customPane implementation.
Imagine you need to customize _TopNavigationPane by creating CustomTopNavigationPane.

Currently, if you try to implement it, you will have to copy the whole _MenuFlyoutPaneItem, which also depends from private PaneItem. _getPropertyFromTitle and NavigationPane._changeTo so you will have to copy it too.

Describe the solution you'd like
Make as public members the following widgets and methods:

PaneItem. _getPropertyFromTitle
_MenuFlyoutPaneItem
_NavigationViewScrollBehavior
NavigationPane._changeTo
_kCompactNavigationPanelWidth
_OpenNavigationPane
_kOpenNavigationPanelWidth
_CompactNavigationPane
_TopNavigationPane
add _overlayKey to NavigationPaneWidgetData

NavigationViewState.PaneScrollConfiguration -> separate widget
export package:fluent_ui/src/utils/popup.dart to library

Describe alternatives you've considered

Additional context

If that's okay, I would like to make these changes and add PR for it.
Will glad for your thoughts!

Please see a draft PR below:
#366 (comment)

@bdlukaa bdlukaa added the enhancement New feature or request label May 23, 2022
@bdlukaa bdlukaa mentioned this issue Jun 10, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants