Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox to ComboboxFormField #373

Closed
catapult0 opened this issue May 27, 2022 · 1 comment · Fixed by #481
Closed

Combobox to ComboboxFormField #373

catapult0 opened this issue May 27, 2022 · 1 comment · Fixed by #481
Labels
enhancement New feature or request

Comments

@catapult0
Copy link

catapult0 commented May 27, 2022 •
edited

Hi,

I'm trying to find an elegant and speedy manner to transform Combobox to a ComboboxFormField. My intention is to use this filed in a regular form and have access to certain FormField class properties and styling, such as :

  • display validation error message, when input is empty for example
  • have initial value property
  • textInputAction
  • etc.

Similarly, AutoSuggestBox could use the same features.

By the way, I found a comment in the Combobox class :
// When adding new arguments, consider adding similar arguments to
// ComboboxFormField.

this "ComboboxFormField" is no where to be found, is it legacy code ?

Anyways, would greatly appreciate a tip from you guys ;) @bdlukaa

Best
@bdlukaa bdlukaa added the enhancement New feature or request label May 28, 2022
@bdlukaa
Copy link
Owner

bdlukaa commented May 28, 2022 •
edited

ref: https://docs.microsoft.com/en-us/windows/apps/design/controls/combo-box#make-a-combo-box-editable

@bdlukaa bdlukaa mentioned this issue Jul 23, 2022
Closed
@bdlukaa bdlukaa linked a pull request Aug 21, 2022 that will close this issue
Combobox updates #481
Merged
3 tasks
bdlukaa added a commit that referenced this issue Aug 21, 2022
@bdlukaa
ComboBox updates (#481)
bddce78 
- `ComboBox` updates:
  - **BREAKING** Renamed `Combobox` to `ComboBox`
  - Implement `EditableComboBox`, a combo box that accepts items that aren't listed ([#244](#244)) 
  - `ComboBox.isExpanded: false` now correctly sets the button width ([#382](#382))
  - `ComboBox`'s items height are correctly calculated, as well as initial scroll offset ([#472](#478))
  - **BREAKING** `ComboBox.disabledHint` was renamed to `ComboBox.disabledPlaceholder`
  - Added `ComboBoxFormField` and `EditableComboBoxFormField` ([#373](#373))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combobox updates bdlukaa/fluent_ui
2 participants
@bdlukaa @catapult0