Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled color foreground on FilledButton #209

Merged
merged 4 commits into from Mar 7, 2022

Conversation

WinXaito
Copy link
Collaborator

@WinXaito WinXaito commented Mar 3, 2022

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

According to the normal button : https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/controls/inputs/buttons/button.dart#L62

image

@WinXaito WinXaito requested a review from bdlukaa March 3, 2022 12:33
@WinXaito WinXaito linked an issue Mar 3, 2022 that may be closed by this pull request
@bdlukaa
Copy link
Owner

bdlukaa commented Mar 6, 2022

I believe the color shouldn't be the same as Button

For light mode:
light_toggle_button
And for dark mode:
dark_toggle_button

@WinXaito
Copy link
Collaborator Author

WinXaito commented Mar 6, 2022

Currently I just fixed the foreground color.
So we need to change the background color.

but I agree with you.

btw how is on Microsoft fluent ?

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 6, 2022

I'm no longer getting based on the web fluent documentation. I take examples on the Windows native apps I find

@WinXaito
Copy link
Collaborator Author

WinXaito commented Mar 7, 2022

image

image


image

image

@bdlukaa ok for you ?

@bdlukaa bdlukaa merged commit 4c0f254 into bdlukaa:master Mar 7, 2022
@WinXaito WinXaito deleted the fix_filledbutton_disabled branch March 7, 2022 17:30
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Wrong disabled color for FilledButton
2 participants