Add isCompact field to CommandBar #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If compactBreakpointWidth is not specified, then indicates whether or not items on the primary area should be displayed in their compact mode.
bdlukaa
requested changes
Mar 22, 2022
bdlukaa
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-on tweak to #232 to add an explicit field
isCompactthat can indicate that the primary display area should display the items in compact mode, without relying oncompactBreakpointWidth. WhilecompactBreakpointWidthis convenient, it was breaking things in some of my more complex layouts that already had aLayoutBuilderin a parent widget higher in the org tree. This allows use of thecompactBreakpointWidthfor convenience in most cases, or complete control over compact mode usingisCompactotherwise. Default behavior has not changed.