Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout rework #253

Merged
merged 9 commits into from
Apr 2, 2022
Merged

Flyout rework #253

merged 9 commits into from
Apr 2, 2022

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented Mar 27, 2022

  • Removed Flyout.contentWidth and added FlyoutContent.constraints. Now the content will be automatically sized and layed out according to the placement
  • Added Flyout.placement which takes a FlyoutPlacement
  • Added Flyout.openMode which takes a FlyoutOpenMode
  • Flyout.controller is no longer required. If not provided, a local controller is created to handle the Flyout.openMode settings
  • Breaking FlyoutController.open is now a function
  • Adedd FlyoutController.isOpen, FlyoutController.isClosed, FlyoutController.close(), FlyoutController.open() and FlyoutController.toggle()

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have added/updated relevant documentation

This was referenced Apr 1, 2022
@bdlukaa bdlukaa marked this pull request as ready for review April 1, 2022 22:58
@bdlukaa bdlukaa merged commit 62b8a8b into master Apr 2, 2022
@bdlukaa bdlukaa deleted the flyout-rework branch April 2, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant