Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian #354

Merged
merged 1 commit into from
May 21, 2022
Merged

Add Persian #354

merged 1 commit into from
May 21, 2022

Conversation

xmine64
Copy link
Contributor

@xmine64 xmine64 commented May 21, 2022

Adding Persian Localization

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@bdlukaa bdlukaa merged commit e137ecb into bdlukaa:master May 21, 2022
@xmine64
Copy link
Contributor Author

xmine64 commented May 21, 2022

when it'll make it to stable release? I tried to use fluent_ui in my app and it crashed just because there was no localization for Persian.

@bdlukaa
Copy link
Owner

bdlukaa commented May 21, 2022

@xmine64 weird! It shouldn't crash. can you file an issue about that crash?

I don't have any ETA for when it'll be published, but you can use the following for now:

dependencies:
  fluent_ui:
    git: https://github.com/bdlukaa/fluent_ui.git

@xmine64
Copy link
Contributor Author

xmine64 commented May 21, 2022

It shouldn't crash. can you file an issue about that crash?

It says it can't find FluentLocalization, while I had DefaultFluentLocalication.delegate in my localization delegates. It was ok when I changed my locale to English but my app was Persian-only and I got error for other parts of my app. I should open an issue?

but you can use the following for now

Sure thanks.

@bdlukaa
Copy link
Owner

bdlukaa commented May 21, 2022

I should open an issue?

It'd be cool to do so, so we can investigate the issue. Please post the error message

@xmine64
Copy link
Contributor Author

xmine64 commented May 26, 2022

Looks like I can't reproduce it in a simple project. in the last project my app was wrapped inside a BetterFeedback widget (https://github.com/ueman/feedback), I had added FluentLocalizationDelegate to its localization delegates too.

Edit: it happens when you use NavigationView.

@henry2man
Copy link
Contributor

#371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants