Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyouts size #435

Merged
merged 4 commits into from Jul 23, 2022
Merged

Flyouts size #435

merged 4 commits into from Jul 23, 2022

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented Jul 23, 2022

Fixes #431

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@bdlukaa
Correctly calculate the Popup height and position based on the prefer…
715306d 
…red position

If preferred is below, we must verify if it'll not overlap at the bottom. If above, we must verify it'll not overlap at the top
@bdlukaa
Clean up the code
13a1229
@bdlukaa
Add tests
4cd06c4
@bdlukaa
Update CHANGELOG.md
dbd6640
@bdlukaa bdlukaa merged commit f933bbb into master Jul 23, 2022
@bdlukaa bdlukaa deleted the flyouts-size branch February 10, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bdlukaa