Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect time display format in TimePicker in Chinese #445

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Fix incorrect time display format in TimePicker in Chinese #445

merged 6 commits into from
Aug 1, 2022

Conversation

rk0cc
Copy link
Contributor

@rk0cc rk0cc commented Jul 31, 2022

  1. Edit Chinese localization of time to more accurate one.
  2. Add mixin that handle Locale script code is applied.
    • This problem only happened in Traditional Chinese. When time is picked, expected to display '時', not '时' which is Simplified because intl package can not recognized with script code given.
    • As a result, a mixin is deployed which convert to locale string that intl can be recognized.
      • In this case: zh_Hant_(country code) will be converted to zh_(country code). If parsed without country code like zh_Hant, it will applied with default country code which in Trad. Chinese is zh_TW.

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@rk0cc rk0cc marked this pull request as ready for review July 31, 2022 03:49
@bdlukaa bdlukaa merged commit 0a82113 into bdlukaa:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants