TreeView: onExpand-callback #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lazy loading - Add global onItemExpandToggle callback to TreeView. - Add onExpandToggle callback to TreeViewItem. -> The global callback gets executed before(!) the item's callback. - Add documentation. These callbacks can be used to load child items lazily, which fixes the unexpected behavior of triggering child loading on invoking an item. The loading of children now can be triggered, when the item gets expanded. Then a loading indicator is shown if the loading takes some time. When loading is complete, the loading indicator is removed and the item gets expanded.
bdlukaa
requested changes
Sep 21, 2022
Showcase example for lazy loading tree view items updated to the new behavior.
bdlukaa
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a global onItemExpandToggle and an item specific onExpandToggle callback function, that can be used to load child items lazily.
This fixes the unexpected behavior of triggering child loading on invoking an item. The loading of children now can be triggered, when the item gets expanded. Then a loading indicator is shown if the loading takes some time. When loading is complete, the loading indicator is removed and the item gets expanded.
Before:
The child items get loaded when the item is invoked.
After:
Nothing happens when the item gets invoked. Child items get loaded when the item gets expanded.
Related Issue: #522
Pre-launch Checklist
CHANGELOG.mdwith my changes