Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigScreen.element needs to check for all <video>s #5

Closed
bdougherty opened this issue Apr 9, 2013 · 1 comment
Closed

BigScreen.element needs to check for all <video>s #5

bdougherty opened this issue Apr 9, 2013 · 1 comment
Assignees

Comments

@bdougherty
Copy link
Owner

It only checks for the one it knows about called explicitly through request(), but it's possible for a <video> to enter fullscreen automatically when it starts (for example, on the iPhone).

I think the best way is to select all videos when element is called and check each one. That means document[fn.element] should be checked first to avoid unnecessary DOM interaction.

@ghost ghost assigned bdougherty Apr 9, 2013
@bdougherty
Copy link
Owner Author

Fixed by bf83a10 (made possible by 4c24faf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant