Allow user to specify activation string #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename INPUT_MESSAGE to INPUT_CONFIRMATION_MESSAGE to be entirely unambiguous about the two messages being requried. add INPUT_ACTIVATION_MESSAGE to env and replace hard coded .take for variable.
users already have inputs.message so renaming this to inputs.confirmation_message would break live. return var to original name.
|
@bdougie I don't suppose you have had a chance to think about any feedback on this, have you? Thanks in advance! |
bdougie
approved these changes
May 12, 2022
|
Thanks @bdougie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
activation_messagevariable to allow users to specify which activation string they want take-action to trigger on.Allows user to specify an activation string that aligns with other platforms. For example, Slack and Discord use / to denote a command, so user can specify
/takeor/mineif they prefer.Provides back compatible defaults so as not to break existing installations.
Resolves #9