Fixed single-axis homing fail with cycle=0. #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix involved adding homing/cycle=0 axes to the homing mask. The problem was introduced via a combination of automatically creating homing sections if they were not explicitly present, along with the way that the default cycle value for such sections was interpreted for the purpose of homing mask. I eliminated the inferred sections, ensuring that code that uses homing sections is careful to check for nonexistent ones. In the process, I factored the tstep calculation in Trinamic drivers so the homing related code is in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix involved adding homing/cycle=0 axes to the homing mask. The problem was introduced via a combination of automatically creating homing sections if they were not explicitly present, along with the way that the default cycle value for such sections was interpreted for the purpose of homing mask. I eliminated the inferred sections, ensuring that code that uses homing sections is careful to check for nonexistent ones. In the process, I factored the tstep calculation in Trinamic drivers so the homing related code is in one place.