Create build-only CI workflow #935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dymk
force-pushed
the
fluidnc-ci-workflow
branch
from
ffffb6d
to
288930b
Compare
This CI workflow triggers a Github action to: - Install PlatformIO at a known version (modulo minor revision) - Runs against Windows, Linux, and MacOS - Builds a number of PlatformIO environments The PlatformIO environments built are initially noradio, wifi, and bt. It is easy to include additional environments, but in the spirit of having a CI which balances speed with catching true-positive failures, we select only these three. In addition, there is support for additional "_s2", "_s3" variants, but for this initial CI pipeline, they are not built, as they greatly increase CI time.
dymk
force-pushed
the
fluidnc-ci-workflow
branch
from
288930b
to
48f72a2
Compare
|
It would be nice if the CI workflow exported the firmware.bin files as artifacts, so one could grab one for testing. It would not be necessary to do it from every build platform, just one each of the bt, wifi, and noradio builds. Would you be willing to add that feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to discussion on Discord regarding having a CI pipeline for FluidNC.
Summary
This CI workflow triggers a Github action to:
The PlatformIO environments built are initially noradio, wifi, and bt. It is easy to include additional environments, but in the spirit of having a CI which balances speed with catching true-positive failures, we select only these three.
In addition, there is support for additional "_s2", "_s3" variants, but for this initial CI pipeline, they are not built, as they greatly increase CI time.
Timing
CI is relatively fast with a warm cache.
The build matrix does not run fully in parallel (free-tier resource limitations), so a full run takes ~8 minutes.
Example
My fork of FluidNC has this action enabled. Here's an example PR opened against that fork, to demonstrate the Checks ran against the changed code: dymk#1
Example action run logs: link