Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable parameter cost check for now #821

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

bdunderscore
Copy link
Owner

This creates compatibility issues with VRCF, as well as being
run in the wrong phase of processing in any case.

At some point this will need to be restored, as part of a new
NDMF processing phase that runs much later in the build.

Fixes: #813, #806

This creates compatibility issues with VRCF, as well as being
run in the wrong phase of processing in any case.

At some point this will need to be restored, as part of a new
NDMF processing phase that runs much later in the build.

Fixes: #813, #806
@bdunderscore bdunderscore merged commit 8d64c63 into main Apr 15, 2024
7 checks passed
@bdunderscore bdunderscore deleted the param-limit-check branch April 15, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PruneParametersPass should be executed before checking the total size of synced parameters
1 participant