Expose animation clone APIs built for MA in NDMF #111
Milestone
Comments
|
FYI: I had to implement VRM-related ScriptableObject clone API in bdunderscore/modular-avatar#602 |
enitimeago
added a commit
to enitimeago/make-it-mmd
that referenced
this issue
Feb 4, 2024
If this was a larger project it may make sense to only do it once in the NDMF resolving phase, but otherwise this is a case of YAGNI. Cloning in the write defaults pass is fine. We can revisit this decision if more passes end up needing this. Ideally bdunderscore/ndmf#111 lands and we can migrate to that instead, since it's already duplicate work for this and Modular Avatar to both do a deep clone of avatar FX
|
What work needs to be done to complete this? Would it be as straightforward as placing a copy (or a portion) of Modular Avatar's Animator folder into NDMF? I was able to get that to work in February by copying AnimatorUtil and AnimatorCombiner: enitimeago/make-it-mmd@d38061d More recently I've tested copying the whole folder and only needed to copy a few extra methods from MA: https://github.com/enitimeago/make-it-mmd/pull/64/files#diff-5969a7e96382bc1f99fd8c9a38e2e6951a1a20884dd5584f78364edc807437aeR27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: