Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Non-VRChat Avatars support #49

Closed
3 tasks done
kaikoga opened this issue Oct 4, 2023 Discussed in #39 · 3 comments
Closed
3 tasks done

feat: Non-VRChat Avatars support #49

kaikoga opened this issue Oct 4, 2023 Discussed in #39 · 3 comments

Comments

@kaikoga
Copy link
Contributor

kaikoga commented Oct 4, 2023 •
edited

Discussed in #39

Remove VRCSDK dependencies from ndmf to support non-VRChat avatars.

Required Tasks

  • Add Version Define NDMF_VRCSDK3_AVATARS against "com.vrchat.avatars"
  • #if NDMF_VRCSDK3_AVATARS VRCSDK component references and public API hooks
  • Cross platform find Avatar root

Optional Tasks (separate issue?)

  • Obsolete duplicate AvatarRoot APIs
  • CI and unit tests without VRCSDK
This was referenced Oct 5, 2023
Merged
Merged
@bdunderscore
Copy link
Owner

CI should now be attempting to run unit tests without VRCSDK - since the unit tests don't work quite yet, I've suppressed the failures (these will show up as "neutral" results)

@kaikoga
Copy link
Contributor Author

kaikoga commented Oct 23, 2023

#68
#69

@kaikoga
Copy link
Contributor Author

kaikoga commented Oct 23, 2023

I think remaining tasks go to separate issue.

@kaikoga kaikoga closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaikoga @bdunderscore